RFR: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" [v2]

Roger Riggs rriggs at openjdk.org
Wed Nov 1 19:53:02 UTC 2023


On Wed, 1 Nov 2023 19:46:33 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5 seconds and then grab the output. Then run `jcmd` to dump the thread stacks in case there is a deadlock. The test ignores and swallows any exception which makes it hard to diagnose test issues. 
>> 
>> This PR simplifies the test to use `jdk.test.lib.process.ProcessTools` to launch `LoadLibraryDeadlock` test so that the output and error will be captured in the same way as other tools are run by this test.   Also update the test to propagate exceptions where appropriate.   This hopes to collect more information to diagnose the issue if this test fails next time.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback: use ProcessTools.createTestJavaProcessBuilder

Looks good.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16459#pullrequestreview-1708972035


More information about the core-libs-dev mailing list