RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2
Joe Darcy
darcy at openjdk.org
Thu Nov 2 02:02:19 UTC 2023
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> I would suggest to determine the set of tests which run "at most 10 seconds total" and run only them in tier1.
>> Also taking into account API coverage.
>
>> I would suggest to determine the set of tests which run "at most 10 seconds total" and run only them in tier1. Also taking into account API coverage.
>
> Okay; I think preserving a handful of tests to check for a dead-on-arrival vector change is acceptable. Here are the sorted running times from my machine, times in milliseconds:
>
> VectorHash.jtr:2190
> PreferredSpeciesTest_id0.jtr:2545
> VectorRuns.jtr:2790
> PreferredSpeciesTest_id1.jtr:3228
> MethodOverideTest.jtr:3864
> CovarOverrideTest.jtr:3993
> MismatchTest.jtr:4013
> LoadJsvmlTest.jtr:4112
> ImageTest.jtr:6074
> LongMaxVectorLoadStoreTests.jtr:6197
> DoubleMaxVectorLoadStoreTests.jtr:6445
> ShortMaxVectorLoadStoreTests.jtr:6692
> IntMaxVectorLoadStoreTests.jtr:6868
> FloatMaxVectorLoadStoreTests.jtr:6952
> ByteMaxVectorLoadStoreTests.jtr:7098
> AddTest.jtr:7303
> -=-=-=-=-=-=-=-=-=-
> VectorMaxConversionTests_ZSinglegen.jtr:24001
> LongMaxVectorTests.jtr:27290
> IntMaxVectorTests.jtr:27349
> VectorMaxConversionTests_id0.jtr:27588
> VectorMaxConversionTests_ZGenerational.jtr:29138
> ShortMaxVectorTests.jtr:29220
> FloatMaxVectorTests.jtr:30849
> ByteMaxVectorTests.jtr:31206
> DoubleMaxVectorTests.jtr:32384
> VectorReshapeTests.jtr:39873
>
> The tests below the line take 24 or more seconds to run so would be out of consideration.
>
> @vnkozlov , which subset of the above the line regressions tests would be most helpful to preserve?
> @jddarcy I think next 3 tests are good for sanity check in tier1:
>
> VectorHash.java VectorRuns.java PreferredSpeciesTest.java
Changeset implementing that pushed.
Double-check on tier1:
$ diff tier1.txt tier1-patched.txt
108,123d107
< jdk/incubator/vector/AddTest.java
< jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java
< jdk/incubator/vector/ByteMaxVectorTests.java
< jdk/incubator/vector/CovarOverrideTest.java
< jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java
< jdk/incubator/vector/DoubleMaxVectorTests.java
< jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java
< jdk/incubator/vector/FloatMaxVectorTests.java
< jdk/incubator/vector/ImageTest.java
< jdk/incubator/vector/IntMaxVectorLoadStoreTests.java
< jdk/incubator/vector/IntMaxVectorTests.java
< jdk/incubator/vector/LoadJsvmlTest.java
< jdk/incubator/vector/LongMaxVectorLoadStoreTests.java
< jdk/incubator/vector/LongMaxVectorTests.java
< jdk/incubator/vector/MethodOverideTest.java
< jdk/incubator/vector/MismatchTest.java
126,127d109
< jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java
< jdk/incubator/vector/ShortMaxVectorTests.java
129,132d110
< jdk/incubator/vector/VectorMaxConversionTests.java#id0
< jdk/incubator/vector/VectorMaxConversionTests.java#ZGenerational
< jdk/incubator/vector/VectorMaxConversionTests.java#ZSinglegen
< jdk/incubator/vector/VectorReshapeTests.java
2410c2388
< Tests found: 2,408
---
> Tests found: 2,386
Tier 2 is unchanged from before the PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16437#issuecomment-1789941119
More information about the core-libs-dev
mailing list