RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

Mandy Chung mchung at openjdk.org
Thu Nov 2 15:57:18 UTC 2023


On Thu, 2 Nov 2023 06:38:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review feedback
>
> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java line 185:
> 
>> 183: 
>> 184:     private static String toLocationString(Path path) {
>> 185:         return path.toUri().getPath();
> 
> Hello Mandy, this looks OK to me. Because the `LoadLibraryDeadlock.getLocation()` uses `URL.getPath()` to print the message in the logs, maybe for consistency and to rule out any unexpected differences, perhaps use `path.toUri().toURL().getPath()` instead?

Ok.  Updated to use consistent format.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16466#discussion_r1380370877


More information about the core-libs-dev mailing list