RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

Vicente Romero vromero at openjdk.org
Fri Nov 3 05:19:14 UTC 2023


On Thu, 2 Nov 2023 20:48:45 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Address changes from JEP 445 to JEP 463.
>> 
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>> 
>> - Don't mark class on read.
>> 
>> - Remove reflection and annotation processing related to unnamed classes.
>> 
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnamed classes from examples.not-yet.txt

src/java.base/share/native/libjli/java.c line 544:

> 542: 
> 543:     /* Build platform specific argument array */
> 544:     mainArgs = CreateApplicationArgs(env, argv, argc);

we build the arguments always even if the main we will end up invoking receives no argument and thus these arguments will be discarded. Could it make sense to create the arguments only if they won't be discarded?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1381163039


More information about the core-libs-dev mailing list