RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v2]

Chen Liang liach at openjdk.org
Fri Nov 3 23:44:08 UTC 2023


On Wed, 25 Oct 2023 12:36:40 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java line 71:
>> 
>>> 69:                                         for (int i = 0; i < type.parameterCount(); i++) {
>>> 70:                                             codeBuilder.loadInstruction(TypeKind.fromDescriptor(
>>> 71:                                                     type.parameterType(i).descriptorString()), i);
>> 
>> You can just use `TypeKind.from(type.parameterType(i))`
>
> I can't see such as method.

It is declared as `public static TypeKind from(TypeDescriptor.OfField<?> descriptor)` so that you can pass either `Class` or `ClassDesc` in.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16268#discussion_r1382289383


More information about the core-libs-dev mailing list