RFR: 8319607: FFM: Review the language in the FFM documentation
Maurizio Cimadamore
mcimadamore at openjdk.org
Tue Nov 7 11:16:29 UTC 2023
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg <pminborg at openjdk.org> wrote:
> This PR proposes to improve the language used in the FFM specification. There is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that" (to be used in a restrictive clause) and "which" (to be used in a non-restrictive clause). Here is a reference: https://preply.com/en/blog/when-to-use-which-or-that-the-most-common-cases
>
> Another source for updates is the difference between BE and AE where most of us Europeans were taught BE but we should use AE in the specifications.
src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 188:
> 186: * }
> 187: *
> 188: * This layout is a struct layout that describe a rectangle. It contains a single field, namely {@code points},
"that describeS" ? Or, "describing"...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16536#discussion_r1384758701
More information about the core-libs-dev
mailing list