RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v2]

Leonid Mesnik lmesnik at openjdk.org
Wed Nov 8 02:08:26 UTC 2023


> Test thread factory is a mode similar to VM flags and should not be used in ProcessTools.createLimitedTestJavaProcessBuilder(). Only createTestJavaProcessBuilder() should use it like jtreg VM options.
> 
> Adding the test thread factory requires the injection of arguments in the middle of the list. I don't think it makes sense to modify arguments in several places so I replaced it with the flag isLimited and moved all modifications in createJavaProcessBuilder().
> 
> Testing tier1-5.

Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8319200
 - param removed
 - Moved ttf from limited builder.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16442/files
  - new: https://git.openjdk.org/jdk/pull/16442/files/0dcf3673..db069ace

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16442&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16442&range=00-01

  Stats: 31452 lines in 728 files changed: 16977 ins; 6081 del; 8394 mod
  Patch: https://git.openjdk.org/jdk/pull/16442.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16442/head:pull/16442

PR: https://git.openjdk.org/jdk/pull/16442


More information about the core-libs-dev mailing list