RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v3]

Leonid Mesnik lmesnik at openjdk.org
Wed Nov 8 05:35:59 UTC 2023


On Wed, 8 Nov 2023 02:33:29 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Test thread factory is a mode similar to VM flags and should not be used in ProcessTools.createLimitedTestJavaProcessBuilder(). Only createTestJavaProcessBuilder() should use it like jtreg VM options.
>> 
>> Adding the test thread factory requires the injection of arguments in the middle of the list. I don't think it makes sense to modify arguments in several places so I replaced it with the flag isLimited and moved all modifications in createJavaProcessBuilder().
>> 
>> Testing tier1-5.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   converted list to array.

Moved the threadFactory injection to createTestJavaProcessBuilder. I think that it is more logical to don't set it for limited version of process builder.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16442#issuecomment-1801121241


More information about the core-libs-dev mailing list