RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]
Adam Sotona
asotona at openjdk.org
Wed Nov 8 13:08:07 UTC 2023
On Tue, 7 Nov 2023 18:56:07 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
>> early experimental version of the bytecode library is bundled under:
>> test/jdk/lib/testlibrary/bytecode
>>
>> following tests reference it:
>> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
>> test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java
>> test/jdk/java/lang/invoke/condy/CondyReturnPrimitiveTest.java
>> test/jdk/java/lang/invoke/condy/CondyWrongType.java
>> test/jdk/java/lang/invoke/condy/CondyNestedTest.java
>> test/jdk/java/lang/invoke/condy/CondyStaticArgumentsTest.java
>> test/jdk/java/lang/invoke/condy/BootstrapMethodJumboArgsTest.java
>> test/jdk/java/lang/invoke/condy/ConstantBootstrapsTest.java
>> test/jdk/java/lang/invoke/condy/CondyRepeatFailedResolution.java
>> test/jdk/java/lang/invoke/condy/CondyBSMInvocation.java
>> test/jdk/java/lang/invoke/condy/CondyTypeValidationTest.java
>> test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java
>> test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java
>> test/jdk/java/lang/invoke/condy/CondyBSMException.java
>> test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java
>
> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>
> - Merge branch 'master' into 8294980
> - Use TypeKind.from .
> - Merge branch 'master' into 8294980
> - specify packages to export in jtreg tests.
> - Remove reference to old bytecode library.
> - Remove early experimental version of the bytecode library.
> - Convert CondyInterfaceWithOverpassMethods .
> - Convert CondyBSMException .
> - Convert CondyNameValidationTest .
> - Convert CondyBSMValidationTest .
> - ... and 11 more: https://git.openjdk.org/jdk/compare/98c74731...c95c1e2f
Looks good.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16268#pullrequestreview-1720305963
More information about the core-libs-dev
mailing list