RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

Eirik Bjorsnos duke at openjdk.org
Wed Nov 8 13:51:03 UTC 2023


On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>> Please review this PR which brings  the DataDescriptorSignatureMissing test back to life.
>> 
>> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore` 
>> 
>> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.
>
> Eirik Bjorsnos has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Describe the structure of Data Descriptors using an example
>  - Extend the comment of `makeZipWithSignaturelessDescriptor` with some background info on (signature-less) data descriptors, for the benefit of future maintainers.
>  - Convert test from testng to junit

> > I can kick of a test run internally next week or perhaps Sunday
> > 
> FWIW, the test ran fine on Github Actions, including on `linux-x86` (which is 32-bit, right?):

Disregard this comment, since it confuses this PR with #12991 :-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12959#issuecomment-1801925790


More information about the core-libs-dev mailing list