RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview)

Rémi Forax forax at openjdk.org
Wed Nov 8 17:59:07 UTC 2023


On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang <vklang at openjdk.org> wrote:

> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)

src/java.base/share/classes/java/util/stream/GathererOp.java line 448:

> 446:             private final long targetSize;
> 447:             private final Hybrid leftPredecessor;
> 448:             private final AtomicBoolean cancelled;

It could be a volatile boolean and a comment is needed saying this field is only be accessed if greedy is true. And inside the constructors this should be the last field of the constructor to be initialized

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387006826


More information about the core-libs-dev mailing list