RFR: JDK-8295391: Add discussion of binary <-> decimal conversion issues [v2]

Joe Darcy darcy at openjdk.org
Wed Nov 8 18:45:02 UTC 2023


On Wed, 8 Nov 2023 18:09:52 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 257:
> 
>> 255:  * <br>// Numeric values listed are exact values
>> 256:  * <br>oneTenthApproxAsFloat = 0.100000001490116119384765625;
>> 257:  * <br>ulpOfoneTenthApproxAsFloat = Math.ulp(1.0f) = 7.450580596923828125E-9;
> 
> Suggestion:
> 
>  * <br>ulpOfoneTenthApproxAsFloat = Math.ulp(0.1f) = 7.450580596923828125E-9;

Fixed; thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16566#discussion_r1387054810


More information about the core-libs-dev mailing list