RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview)

[Alan Bateman]

On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang <vklang at openjdk.org> wrote:

> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)

src/java.base/share/classes/java/util/stream/Gatherer.java line 38:

> 36: /**
> 37:  * An intermediate operation that transforms a stream of input elements into a
> 38:  * stream of output elements, optionally applying a final action when the end of

It looks like the javadoc uses "final action" in some places and "final operation" in others.

src/java.base/share/classes/java/util/stream/Gatherer.java line 194:

> 192:      * this gathering operation.
> 193:      *
> 194:      * <p>By default, this method returns {@link #defaultInitializer()}

default methods usually have `@implSpec` for the text that specifies what the default implementation does.

src/java.base/share/classes/java/util/stream/Stream.java line 1107:

> 1105:      */
> 1106:     @PreviewFeature(feature = PreviewFeature.Feature.STREAM_GATHERERS)
> 1107:     default <R> Stream<R> gather(Gatherer<? super T, ?, R> gatherer) {

This one will need an `@since`. Also I think you'll need to add this tag to the Gatherer.Integrator and the other Gatherer.* interfaces.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387125271
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387131604
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387104906