RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview)

Viktor Klang vklang at openjdk.org
Wed Nov 8 20:18:06 UTC 2023


On Wed, 8 Nov 2023 19:46:42 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 38:
> 
>> 36: /**
>> 37:  * An intermediate operation that transforms a stream of input elements into a
>> 38:  * stream of output elements, optionally applying a final action when the end of
> 
> It looks like the javadoc uses "final action" in some places and "final operation" in others.

Gotcha—going with "final action".

> src/java.base/share/classes/java/util/stream/Stream.java line 1107:
> 
>> 1105:      */
>> 1106:     @PreviewFeature(feature = PreviewFeature.Feature.STREAM_GATHERERS)
>> 1107:     default <R> Stream<R> gather(Gatherer<? super T, ?, R> gatherer) {
> 
> This one will need an `@since`. Also I think you'll need to add this tag to the Gatherer.Integrator and the other Gatherer.* interfaces.

Wilco 👍

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387152669
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387153071


More information about the core-libs-dev mailing list