RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v3]
Lance Andersen
lancea at openjdk.org
Wed Nov 8 20:38:59 UTC 2023
On Wed, 8 Nov 2023 13:54:23 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
> > > > I think the changes look good overall. Thank you for this. I am not sure that the `@requires` is needed at this point.
> > >
> > >
> > > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB memory requirement? If so, I guess we can safely remove the requires tag, even though the test still creates a ~2GB sparse file?
> >
> >
> > We would have to run across all of the mach5 platforms to verify. You could remove it for now and we go from here
>
> FWIW, this test ran successfully on `linux-x86` on Github Actions (which is 32 bit?):
>
> ```
> TEST: java/util/zip/ZipFile/CenSizeTooLarge.java
> build: 0.059 seconds
> compile: 0.059 seconds
> junit: 2.437 seconds
> TEST RESULT: Passed. Execution successful
> ```
I have an internal mach5 run going. Once it completes, I will approve once again and you can push the PR
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12991#issuecomment-1802637172
More information about the core-libs-dev
mailing list