RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v2]

Per Minborg pminborg at openjdk.org
Thu Nov 9 08:26:10 UTC 2023


On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Addressing review feedback
>  - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type

src/java.base/share/classes/java/util/stream/Gatherer.java line 267:

> 265:      * @param <A> the type of the state of the returned initializer
> 266:      */
> 267:     static <A> Supplier<A> defaultInitializer() {

Would code sharing imply performance implications due to profile pollution?

src/java.base/share/classes/java/util/stream/Gatherer.java line 419:

> 417:      * @return the new {@code Gatherer}
> 418:      */
> 419:     static <T, R> Gatherer<T, Void, R> of(

Nit: In `Collector` the parameters are formatted in a different way. Should we be consistent with that existing formatting?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387636158
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387638833


More information about the core-libs-dev mailing list