RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v2]

[Per Minborg]

On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Addressing review feedback
>  - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type

src/java.base/share/classes/java/util/stream/Gatherers.java line 326:

> 324: 
> 325:     /**
> 326:      * Gathers elements into fixed-size windows. The last window may contain

Returns a ...

src/java.base/share/classes/java/util/stream/Gatherers.java line 347:

> 345:      * @throws IllegalArgumentException when windowSize is less than 1
> 346:      */
> 347:     public static <TR> Gatherer<TR, ?, List<TR>> windowFixed(int windowSize) {

In my opinion, it would be nicer to let `Gatherers` be a shopping window for cool gatherers. Ideally, I think only the docs, methods, parameters, and invariant assertions should be visible here. The rest could be tucked away under the covers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387675852
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1387674874