RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v2]

Alan Bateman alanb at openjdk.org
Thu Nov 9 14:44:12 UTC 2023


On Thu, 9 Nov 2023 09:42:41 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/stream/Gatherers.java line 326:
>> 
>>> 324: 
>>> 325:     /**
>>> 326:      * Gathers elements into fixed-size windows. The last window may contain
>> 
>> Returns a ...
>
> You mean "Returns a Gatherer which gathers elements into ..." ?

Is "window" defined anywhere? If you are doing another pass over the docs then the windowXXX methods could be expanded a bit to explain this grouping concept. Also it could say that the last windows (if it exists, the empty stream is the corner case) has at least one element.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1388076803


More information about the core-libs-dev mailing list