RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v2]

[Viktor Klang]

On Thu, 9 Nov 2023 14:26:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Addressing review feedback
>>  - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.base/share/classes/java/util/stream/Gatherers.java line 543:
> 
>> 541:      * @throws NullPointerException if any of the parameters are null
>> 542:      */
>> 543:     public static <T, R> Gatherer<T, ?, R> scan(
> 
> The examples (as code snippets) in the windowXXX and fold methods are great. It might help to add one to scan too as some readers might not know what prefix scan is, or they wonder if this is scan left or right.

Yeah, that's fair. I'll see if I can add something palatable. 👍

> src/java.base/share/classes/java/util/stream/Stream.java line 1093:
> 
>> 1091:      *
>> 1092:      * @implNote Implementations of this interface should provide their own
>> 1093:      * implementation of this method.
> 
> I think the sentence goes in the implSpec as it tells implementers that they must override this method.
> 
> The `@see Gatherer` it probably not needed as the method already links to Gatherer.

Ok, will make that change!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1388581857
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1388582664