RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v5]

Joe Darcy darcy at openjdk.org
Fri Nov 10 06:04:01 UTC 2023


On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed behavior on len == 0.

Looks fine.

May want to add some assert to verify the stated pre-conditions hold.

-------------

Marked as reviewed by darcy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16449#pullrequestreview-1724068755


More information about the core-libs-dev mailing list