RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v3]

[Viktor Klang]

On Fri, 10 Nov 2023 17:10:56 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Multiple improvements to Gatherer and Gatherers javadoc and restructuring of Gatherers.java to put public at the top of the file.
>>  - Augmenting Gatherer tests to include default implementation in Stream
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 45:
> 
>> 43:  * or be parallelized -- if a combiner function is supplied.
>> 44:  *
>> 45:  * <p>Examples of gathering operations include, but is not limited to:
> 
>> Examples of ... but _are_ not limited to

Will go with a different wording.

> src/java.base/share/classes/java/util/stream/Gatherer.java line 115:
> 
>> 113:  * Gatherer<Object, ?, String> toString = map(i -> i.toString());
>> 114:  *
>> 115:  * Gatherer<Integer, ?, String> incrementThenToString = plusOne.andThen(intToString);
> 
> Suggestion:
> 
>  * Gatherer<Integer, ?, String> incrementThenToString = increment.andThen(intToString);

Will fix, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1389959973
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1389960616