RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v3]

Viktor Klang vklang at openjdk.org
Fri Nov 10 22:17:10 UTC 2023


On Fri, 10 Nov 2023 17:34:48 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Multiple improvements to Gatherer and Gatherers javadoc and restructuring of Gatherers.java to put public at the top of the file.
>>  - Augmenting Gatherer tests to include default implementation in Stream
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 492:
> 
>> 490:          *
>> 491:          * @apiNote This is best-effort only, once this returns true it should
>> 492:          *          never return false again for the same instance.
> 
> Suggestion:
> 
>          * @apiNote This is best-effort only, once this returns {@code true} it should
>          *          never return {@code false} again for the same instance.

Will fix all of these :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1389975495


More information about the core-libs-dev mailing list