RFR: 8287843: File::getCanonicalFile doesn't work for \\?\C:\ style paths DOS device paths [v7]

[Brian Burkhalter]

On Sat, 11 Nov 2023 11:18:04 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8287843: Remove unused constant and method from WindowsPrefixes test
>
> test/jdk/java/io/File/GetAbsolutePath.java line 76:
> 
>> 74:     public void windows(String path, String absolute) throws IOException {
>> 75:         assertEquals(absolute.toLowerCase(),
>> 76:                      new File(path).getAbsolutePath().toLowerCase());
> 
> WinNTFileSystem.compareTo uses compareToIgnoreCase so this test should probably do the same.

So changed in 2f31318530d7093dc69c07115c5d46b63612ff4b.

> test/jdk/java/io/File/WindowsPrefixes.java line 27:
> 
>> 25:  * @bug 8287843
>> 26:  * @summary Basic test for Windows path prefixes
>> 27:  * @requires (os.family == "windows")
> 
> Given the `@requires` then I assume `@EnabledOnOs(OS.WINDOWS)` can be dropped from the test methods.

Indeed the `@EnabledOnOs` are pointless here. Removed in 2f31318530d7093dc69c07115c5d46b63612ff4b.

> test/jdk/java/io/File/WindowsPrefixes.java line 54:
> 
>> 52:                          Arguments.of("C:\\foo"),
>> 53:                          Arguments.of("C:foo"),
>> 54:                          Arguments.of("C:\\foo\\bar"));
> 
> I suppose this should include `\foo` in the list too.

Included in 2f31318530d7093dc69c07115c5d46b63612ff4b.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15603#discussion_r1391604968
PR Review Comment: https://git.openjdk.org/jdk/pull/15603#discussion_r1391603346
PR Review Comment: https://git.openjdk.org/jdk/pull/15603#discussion_r1391604363