Integrated: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Eirik Bjorsnos duke at openjdk.org
Tue Nov 14 07:32:48 UTC 2023


On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> Please review this PR which brings  the DataDescriptorSignatureMissing test back to life.
> 
> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore` 
> 
> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.

This pull request has now been integrated.

Changeset: 07eaea8c
Author:    Eirik Bjorsnos <eirbjo at gmail.com>
Committer: Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/07eaea8c25bae6ed852685f082f8b50c5b20c1a9
Stats:     158 lines in 1 file changed: 52 ins; 38 del; 68 mod

8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Co-authored-by: Jaikiran Pai <jpai at openjdk.org>
Reviewed-by: jpai, lancea, iris

-------------

PR: https://git.openjdk.org/jdk/pull/12959


More information about the core-libs-dev mailing list