RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

[Stewart X Addison]

On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison <duke at openjdk.org> wrote:

>> ~~I will force push to change ONLY the commit message once I get a bug created - I am not currently an author. In draft until I do that.~~ Done
>> 
>> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin
>> 
>> This fixes a build break which has shown up on 32-bit Windows (Deprecated but not removed in [JEP 449](https://openjdk.org/jeps/449)).
>> Found initially in JDK21, but now also affecting JDK17 where Win32 is still fully supported. I intend to get this into 22 then request a backport to all affected versions. This will need to get in before the January CPU to avoid breaking this platform in the next JDK17 release.
>> 
>> Introduced by https://github.com/openjdk/jdk/commit/3ef834fc6fc245accffc41da714358fc82f22657 under https://github.com/openjdk/jdk/pull/12397 in February
>> In JDK21: https://github.com/openjdk/jdk21u/commit/3ef834fc6fc245accffc41da714358fc82f22657#diff-6a0b6da94fe13f6caf3b50072a6bef7d559c4b5fc92de7aa2e3c0079f33190d3
>> That change was backported to JDK17 three weeks ago in https://github.com/openjdk/jdk17u/commit/f85053f578125d1af7c3c762d966fee8283a6ce2
>
> Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8319958: Fix ifdef to support WIN32 in libGetXSpace.c
>   
>   Signed-off-by: Stewart X Addison <sxa at redhat.com>

Looks like they've all passed 👍

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16628#issuecomment-1810700329