RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

Justin Lu jlu at openjdk.org
Tue Nov 14 17:46:31 UTC 2023


On Tue, 14 Nov 2023 17:16:59 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Correcting the explanation of the `DateFormat.SHORT` constant.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reflects review comments

src/java.base/share/classes/java/text/DateFormat.java line 122:

> 120:  * <ul><li>{@link #SHORT} is the shortest and mainly numeric, such as {@code 12.13.52} or {@code 3:30pm}
> 121:  * <li>{@link #MEDIUM} is longer, such as {@code Jan 12, 1952}
> 122:  * <li>{@link #LONG} is longer, such as {@code January 12, 1952} or {@code 3:30:32pm}

Does it make sense to change LONG to "_is even longer_" or "_is longer than MEDIUM_"?

Still keeps it abstract but clarifies it a little more IMO (and should still hold true regardless of locale)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16645#discussion_r1392996202


More information about the core-libs-dev mailing list