RFR: 8319567: Update java/lang/invoke tests to support vm flags [v2]

[Mandy Chung]

On Wed, 15 Nov 2023 00:17:56 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review feedback
>
> test/jdk/java/lang/ClassLoader/getResource/GetResource.java line 166:
> 
>> 164:         Map<String,String> env = pb.environment();
>> 165:         String value = env.remove("CLASSPATH");
>> 166: 
> 
> Looking into the implementation, it seems that the `CLASSPATH` environment variable is only cleared when `test.noclasspath` == true:
> 
> 
>         if (noCP) {
>             // clear CLASSPATH from the env
>             pb.environment().remove("CLASSPATH");
>         }
> 
> 
> (This seems to be contrary to the doc comment on `createTestJavaProcessBuilder` though, which says that _unless_ `test.noclasspath` is true, the env. var will be cleared).
> 
> Should this test be run with `-Dtest.noclasspath=true`?

I updated the test to remove `CLASSPATH` env var.   We should file an issue for the ProcessTools javadoc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16666#discussion_r1393564565