RFR: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
Jaikiran Pai
jpai at openjdk.org
Wed Nov 15 09:30:31 UTC 2023
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg <pminborg at openjdk.org> wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
test/jdk/java/foreign/TestLayouts.java line 223:
> 221: public void testSequenceLayoutWithZeroLength() {
> 222: SequenceLayout layout = MemoryLayout.sequenceLayout(0, JAVA_INT);
> 223: assertEquals(layout.toString().toLowerCase(Locale.ROOT), "[0:i4]");
Hello Per, I don't yet have experience with these APIs; do you think the implementation of `toString()` itself should perhaps be changed to return a consistent value that doesn't depend on the endianness? Or is it intentional that there is a dependency?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16672#discussion_r1393908097
More information about the core-libs-dev
mailing list