RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]
Andrey Turbanov
aturbanov at openjdk.org
Fri Nov 17 18:36:53 UTC 2023
On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressing trailing whitespace complaint
src/java.base/share/classes/java/util/stream/Gatherers.java line 492:
> 490: @Override BiConsumer<A, Downstream<? super R>> finisher) implements Gatherer<T, A, R> {
> 491:
> 492: static <T, A, R> GathererImpl<T, A, R> of(
method seems unused
src/java.base/share/classes/java/util/stream/Gatherers.java line 564:
> 562: }
> 563:
> 564: static final <T, A, R, AA, RR> GathererImpl<T, ?, RR> impl(
nit
Suggestion:
static <T, A, R, AA, RR> GathererImpl<T, ?, RR> impl(
src/java.base/share/classes/java/util/stream/ReferencePipeline.java line 710:
> 708:
> 709: @Override
> 710: public <R> R collect(Supplier<R> supplier,
alignment of parameters is lost here
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397723227
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397723825
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397725659
More information about the core-libs-dev
mailing list