RFR: JDK-8319626: Override toString() for ZipFile [v2]

Justin Lu jlu at openjdk.org
Fri Nov 17 22:54:44 UTC 2023


On Thu, 16 Nov 2023 11:22:36 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> @justin-curtis-lu, for inspiration and consistency, you might want to have a look at this implementation: https://github.com/openjdk/jdk/blob/1d9688667e667dc710d64e52f1e918e047beaca3/src/java.base/share/classes/java/util/concurrent/CompletableFuture.java#L2605-L2628
>
> Generally, search codebase for `super.toString()` to get some idea as to how people incorporate superclass `toString()` into subclass one.

Thanks Pavel and Alan. 

I updated the return value to be separated by '@'. I also updated the specification wording so that users will be cautious when using this value as @ecki suggested. I used phrasing similar to the second example in Effective Java Item 12. I expect the 'subject to change' will ensure people do not depend on it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16643#discussion_r1397968957


More information about the core-libs-dev mailing list