RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v8]

Naoto Sato naoto at openjdk.org
Sun Nov 19 01:54:36 UTC 2023


On Sat, 18 Nov 2023 14:56:47 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Now I tried and it didn't compile 🙂 It should have been `t.query(TemporalQueries.chronology()) instanceof IsoChronology`
>
> JapaneseChronology is an IsoChronology so run the test again (before committing) to make sure.

`JapaneseChronology` is not extending `IsoChronology`, and that is the gist of the change I suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16033#discussion_r1398306647


More information about the core-libs-dev mailing list