RFR: 8319928: Exceptions thrown by cleanup actions should be handled correctly [v6]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Nov 20 14:56:05 UTC 2023


> This simplePR tweaks the factory which wraps custom cleanup actions passed to `MemorySegment::reinterpret`, so that any exception thrown by the custom cleanup is swallowed when the arena is closed.
> 
> This aligns the behavior of confined/shared session with that of implicit session (as implicit sessions are backed by a `Cleaner`, there is no way for cleanup exception to bubble up).

Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge branch 'master' into swallow_cleanup_exceptions
 - Merge branch 'master' into swallow_cleanup_exceptions
 - Add test to check for self-suppression
 - Drop unused import
 - Address CSR comments
 - More javadoc tweaks
 - Tweak javadoc
 - Catch all cleanup failures in `CleanupException`
 - Initial push

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16619/files
  - new: https://git.openjdk.org/jdk/pull/16619/files/b1dde897..37b6a033

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16619&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16619&range=04-05

  Stats: 611705 lines in 972 files changed: 82566 ins; 469878 del; 59261 mod
  Patch: https://git.openjdk.org/jdk/pull/16619.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16619/head:pull/16619

PR: https://git.openjdk.org/jdk/pull/16619


More information about the core-libs-dev mailing list