RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

[Eirik Bjorsnos]

On Tue, 21 Nov 2023 21:16:41 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> So it's not clear to me why this test uses a jar file at all, it does not seem necessary.

On a closer look, `${TESTCLASSES}` contains the compiled java classes, but not the service definition file `META-INF/services/javax.script.ScriptEngineFactory`. That probably explains the jar file.

Adding `${TESTSRC}` to the class paths would incude the service definition file:


-classpath "${TESTCLASSES}${PS}${TESTSRC}"


But perhaps not a big improvement.  Might be better to spend efforts re-writing this in Java, as suggested by Alan.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16585#issuecomment-1822463159