RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v12]
Roger Riggs
rriggs at openjdk.org
Mon Nov 27 17:31:22 UTC 2023
On Mon, 27 Nov 2023 13:43:52 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply StringUTF16.coderFromArrayLen
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8584:
>
>> 8582: evpcmpuw(mask1, tmp1Reg, tmp2Reg, Assembler::le, Assembler::AVX_512bit);
>> 8583: kortestdl(mask1, mask1);
>> 8584: jcc(Assembler::carryClear, reset_for_copy_tail);
>
> Suggestion:
>
> jccb(Assembler::carryClear, reset_for_copy_tail);
>
>
> and here:
>
> https://github.com/openjdk/jdk/blob/d201344b631bf2cc9fb1990874fc7d42d523eeab/src/hotspot/cpu/x86/macroAssembler_x86.cpp#L8590
Thanks for the suggestions to use byte offset branches.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16425#discussion_r1406506896
More information about the core-libs-dev
mailing list