RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh [v2]

Jaikiran Pai jpai at openjdk.org
Tue Nov 28 11:35:12 UTC 2023


On Wed, 22 Nov 2023 17:57:22 GMT, Gaurav Chaudhari <duke at openjdk.org> wrote:

>> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo. When running without security manager, the test references 'badfactoty.jar' instead of 'badfactory.jar'. This change addresses this by correcting the jar name.
>
> Gaurav Chaudhari has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8319668: Fixup of jar filename typo in BadFactoryTest.sh

Hello Gaurav, the change looks good to me. I ran the test/jdk/javax/script tests with this change in our CI and they continue to pass. I'll go ahead and sponsor this.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16585#pullrequestreview-1752668321


More information about the core-libs-dev mailing list