RFR: 8318971: Better Error Handling for Jar Tool Processing of "@File" [v5]

Ryan Wallace duke at openjdk.org
Tue Nov 28 12:18:23 UTC 2023


> Hi all,
> 
> Please review this fix for jar tool not producing an archive if there is a missing file supplied.
> The current behaviour will recognise missing files as an error but continue processing,
> creating a temporary archive and then deleting it without moving to the current directory.
> The fix is to return false when a missing file is supplied and exit immediately without continuing with any wasted processing.
> 
> Thanks,
> Ryan.

Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge branch 'master' into 8318971
 - 8318971: Better Error Handling for Jar Tool Processing of "@File"
 - Merge branch 'master' into 8318971
 - Merge branch 'master' into 8318971
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
 - Merge branch 'master' into 8318971
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did
 - 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16423/files
  - new: https://git.openjdk.org/jdk/pull/16423/files/cee20934..374e7bff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16423&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16423&range=03-04

  Stats: 14693 lines in 623 files changed: 10624 ins; 2285 del; 1784 mod
  Patch: https://git.openjdk.org/jdk/pull/16423.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16423/head:pull/16423

PR: https://git.openjdk.org/jdk/pull/16423


More information about the core-libs-dev mailing list