Revisiting JDK-4512189: ZipConstants leaking into public APIs

[Lance Andersen]

I agree, I am not sure there is a large benefit to changing this at this time.  Seems a lot of effort for minimal gain at best.

On Nov 28, 2023, at 12:15 PM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:

On 28/11/2023 15:50, Eirik Bjørsnøs wrote:
:

In light of this, I would like to revisit this issue, 22 years later:

- Is my assessment that this change is actually not binary incompatible sound, or did I miss something?
- Would it in any case make sense to mark ZipConstants as @Deprecated, maybe for removal to alert people we want to remove the constants?
- Could we aim to make the mentioned classes *not* implement ZipConstants, following the regular deprecation process, CSR and release note etc?

This is a JDK 1.1 era mistake. It would a source incompatible change to "remove" the constants. It would require corpus searches to gauge the impact. I think the question is whether it's worth the disruption, is your motivation to cleanup this area or something stronger?

-Alan

[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC at home]






Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20231128/29187c63/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: oracle_sig_logo.gif
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20231128/29187c63/oracle_sig_logo-0001.gif>