RFR: 8320608: Many jtreg printing tests are missing the @printer keyword [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu Nov 30 17:37:12 UTC 2023
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race <prr at openjdk.org> wrote:
>> Many printing tests do not have the @printer keyword. This adds them to those that need it.
>> I also found one test that has nothing to do with printing in the print folder and moved it out.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 8320608
Looks good to me
…except for some minor comments.
test/jdk/java/awt/print/PrinterJob/RemoveListener.java line 28:
> 26: * @bug 4459889
> 27: * @summary No NullPointerException should occur.
> 28: * @key printer
Suggestion:
* @test
* @bug 4459889
* @key printer
* @summary No NullPointerException should occur.
To be consistent with other tests.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16785#pullrequestreview-1758016744
PR Review Comment: https://git.openjdk.org/jdk/pull/16785#discussion_r1411002236
More information about the core-libs-dev
mailing list