RFR: JDK-8317631: Refactor ChoiceFormat tests to use JUnit

Naoto Sato naoto at openjdk.org
Fri Oct 6 16:57:09 UTC 2023


On Thu, 5 Oct 2023 20:57:07 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which refactors the ChoiceFormat tests to use JUnit.

test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 78:

> 76:                 "Mutating array returned from getter changed internals of ChoiceFormat");
> 77: 
> 78:         // Modify the array passed to setFormats() -> dayOfWeekNames

I think we should keep the `err` variable, and not throw an exception (and end the test) here. Otherwise, the test after this will not run.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16065#discussion_r1348978190


More information about the core-libs-dev mailing list