RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

Justin Lu jlu at openjdk.org
Fri Oct 6 21:07:55 UTC 2023


On Fri, 6 Oct 2023 18:57:36 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reflect review comments
>
> test/jdk/java/text/testlib/HexDumpReader.java line 54:
> 
>> 52: 
>> 53:     // Converts a Hex dump file (File) into an InputStream containing bytes
>> 54:     public static InputStream getStreamFromHexDump(File hexFile) {
> 
> Maybe add a comment of the expected format of the file passed to this method.

Thanks for the review. Updated the documentation to describe the format that the hex dump file should be in, and examples.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16075#discussion_r1349317616


More information about the core-libs-dev mailing list