RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild
Alexander Matveev
almatvee at openjdk.org
Fri Oct 6 23:31:37 UTC 2023
- Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` CLI options to jpackage to provide signing identity directly to `codesign` and `productbuild` tools as per CSR [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
- If `codesign` or `productbuild` fails, then output of these tools will be printed to stdout to help user diagnose issues with signing using new options. Examples with sign identity set to "test" which does not exist on system:
> Error: "codesign" failed with following output:
> test: no identity found
> Error: "productbuild" failed with following output:
> productbuild: error: Cannot write product to "/Users/SOMEDIR/Test-1.0.pkg". (Could not find appropriate signing identity for “test”.)
- Added error handling not to allow invalid combinations of signing options.
- Updated signing tests to test new changes.
-------------
Commit messages:
- 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild
Changes: https://git.openjdk.org/jdk/pull/16085/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16085&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8311877
Stats: 550 lines in 24 files changed: 463 ins; 23 del; 64 mod
Patch: https://git.openjdk.org/jdk/pull/16085.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16085/head:pull/16085
PR: https://git.openjdk.org/jdk/pull/16085
More information about the core-libs-dev
mailing list