Integrated: JDK-8317633: Modernize text.testlib.HexDumpReader

Justin Lu jlu at openjdk.org
Mon Oct 9 23:00:08 UTC 2023


On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which cleans up the static test utility class _HexDumpReader_.
> 
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with _HexFormat_, and simplifies the File processing by using a stream. Changes were tested to ensure that the _text_ tests are still getting equivalent ByteArrayInputStreams as before.

This pull request has now been integrated.

Changeset: 8e0686b0
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8e0686b0658eb593bdf36e1c179a4b156fee26bf
Stats:     87 lines in 1 file changed: 12 ins; 58 del; 17 mod

8317633: Modernize text.testlib.HexDumpReader

Reviewed-by: lancea, naoto, mli

-------------

PR: https://git.openjdk.org/jdk/pull/16075


More information about the core-libs-dev mailing list