RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key

Alan Bateman alanb at openjdk.org
Tue Oct 10 08:50:05 UTC 2023


On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file.

src/java.base/share/classes/java/util/zip/ZipFile.java line 1424:

> 1422:                             return file.getCanonicalFile();
> 1423:                         } catch (IOException e) {
> 1424:                             throw new RuntimeException(e);

Mapping to RuntimeException doesn't look right here, instead need to use PrivilegedExceptionAction here and changing the Key constructor to throw IOException.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1351889427


More information about the core-libs-dev mailing list