RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key

Chen Liang liach at openjdk.org
Tue Oct 10 10:22:44 UTC 2023


On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file.

src/java.base/share/classes/java/util/zip/ZipFile.java line 1418:

> 1416: 
> 1417:             @SuppressWarnings("removal")
> 1418:             private File getCanonicalFile(File file) {

Suggestion:

            private static File getCanonicalFile(File file) {

To avoid this-escape.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1352104428


More information about the core-libs-dev mailing list