RFR: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements [v2]

Claes Redestad redestad at openjdk.org
Tue Oct 10 14:06:07 UTC 2023


On Tue, 10 Oct 2023 13:47:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test cases, make set sizing more explicit
>
> test/jdk/java/util/BitSet/ImmutableBitSet.java line 65:
> 
>> 63:     @Test
>> 64:     void basic() {
>> 65:         IntStream.of(0, 16, 143, 4711).forEach(k -> basic(k));
> 
> A test on either side of the boundary (128) in the implementation might be useful.

Thanks for reviewing. I added a few cases and made the `BitSet` creation more explicit w.r.t. size.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16094#discussion_r1352576966


More information about the core-libs-dev mailing list