RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v4]
Matthias Baesken
mbaesken at openjdk.org
Wed Oct 11 13:02:08 UTC 2023
On Wed, 11 Oct 2023 10:57:24 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system lead to double pids in the child list; at least intermittent. Using the API getprocs64() instead I was able to eliminate those double pids (and increase the performance by a factor of 4). Otherwise we would have to add an algorithm to filter out the doubles after creating the raw list.
>
> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>
> cosmetic changes 2
`/* skip files that aren't numbers */`
The comment is probably outdated and from the time when we looked at /proc fs in the old version .
So maybe adjust the comment or remove it if it is obsolete now ?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16051#issuecomment-1757645051
More information about the core-libs-dev
mailing list