RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v4]
Roger Riggs
rriggs at openjdk.org
Wed Oct 11 13:55:59 UTC 2023
On Wed, 11 Oct 2023 12:20:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Hi Thomas, this function is just the same as the linux and macos implementation. And I do not want to make more changes as really needed, otherwise the siblings character gets lost. Following your proposal means to do the split for linux and macos too. And to be honest, I do not really know the intention of the function, maybe the implementation is wrong on all platforms. So my goal was to only exchange the used API and keep everything else as on linux. This is my defensive approach.
>
> Probably keep the function without split into 2 functions, but just adjust the comment a bit as Thomas suggested ?
The callers in ProcessHandlerImpl depend on knowing the parent pid for each process.
They are used to find the descendants of a process. When reading /proc that's necessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16051#discussion_r1355048484
More information about the core-libs-dev
mailing list