RFR: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory [v2]

Brian Burkhalter bpb at openjdk.org
Wed Oct 11 15:45:30 UTC 2023


On Wed, 11 Oct 2023 15:22:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal.java line 115:
>> 
>>> 113:         }
>>> 114: 
>>> 115:         assertTrue(failures == 0);
>> 
>> Suggestion:
>> 
>>         assertEquals(0, failures);
>> 
>> Gives a better message because it explicitly knows both the expected value (1st arg) and the actual value (2nd arg).
>> Similarly for other `assertTrue` usages below).
>
> Good suggestion! Thanks. I'll change it.

So changed in 3f4fc63d3f1657caef467e2fa09d846d750dcad4.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16130#discussion_r1355250130


More information about the core-libs-dev mailing list