RFR: JDK-8317372: Refactor some NumberFormat tests to use JUnit [v2]
Naoto Sato
naoto at openjdk.org
Wed Oct 11 22:02:19 UTC 2023
On Wed, 11 Oct 2023 21:15:42 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 62:
>>
>>> 60: // currencySymbolsTest() is only ran for COMPAT
>>> 61: private static final boolean isCompat =
>>> 62: "COMPAT".equals(System.getProperty("java.locale.providers"));
>>
>> This check could be moved into `currencySymbolsTest()`
>
> I left it as a static declaration as although it is used in `currencySymbolsTest()`, it is also used in the data provider of `CurrencyFormatTest()`.
Missed that. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16035#discussion_r1355821515
More information about the core-libs-dev
mailing list