RFR: JDK-8077371: Binary files in JAXP test should be removed [v8]

Lance Andersen lancea at openjdk.org
Thu Oct 12 17:19:34 UTC 2023


On Wed, 11 Oct 2023 19:27:46 GMT, Joe Wang <joehw at openjdk.org> wrote:

> Thanks for the update.
> 
> I'm not sure it's necessary to repeat tests with Base64 input. I think Daniel's comment was that the data can be optionally base64-encoded into a string, not that the tests needed to be duplicated.
> 
> The generatePseudoCodeFor... methods in the Util class can be consolidated too.

Yes it does look like there is duplication where the tests are run using a byte array which represents the serialized object and a second time using a Base64 representation.  We do not need both as the intent of the original test is to validate that the serialized object can be read across the JDK versions

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13537#issuecomment-1760036070


More information about the core-libs-dev mailing list